Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent issue in SingleSignOutFilter#doFilter method #874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taydy
Copy link

@taydy taydy commented Jan 20, 2024

Fix concurrency issues in SingleSignOutFilter#doFilter method.

In the SingleSignOutFilter#doFilter method, synchronization is added to prevent concurrent execution and ensure thread safety.
Before the repair, if SingleSignOutFilter#init is not executed for initialization, when multiple threads execute concurrently, one thread may be executing the HANDLER.init() method, the safeParameters in SingleSignOutHandler have not yet been initialized, and other threads have begun executing HANDLER.process(request, response), which will causes the program to throw a NullPointerException.

@taydy
Copy link
Author

taydy commented Jan 22, 2024

@mmoayyed Could you please take a look at this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant